Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electra: updated get_next_sync_committee_indices #14164

Merged

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Feature

What does this PR do? Why is it needed?

ethereum/consensus-specs#3783

Which issues(s) does this PR fix?

Updates get_next_sync_committe_indices to use electra max eb.

Other notes for review

Reviewers may notice that this is more code branching in prior fork logic, which I have been against. I plan to revisit this after devnet-1 is feature complete.

@prestonvanloon prestonvanloon requested a review from a team as a code owner June 28, 2024 20:27
@prestonvanloon prestonvanloon force-pushed the electra-updated-get_next_sync_committee_indices branch from b61491f to 9a7f4f3 Compare June 28, 2024 20:27
@prestonvanloon prestonvanloon added the Electra electra hardfork label Jun 28, 2024
@prestonvanloon prestonvanloon force-pushed the electra-updated-get_next_sync_committee_indices branch from 9a7f4f3 to 8a7f27f Compare June 28, 2024 20:39
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the comment made about revisiting after devnet1

@prestonvanloon prestonvanloon added this pull request to the merge queue Jun 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 30, 2024
@prestonvanloon prestonvanloon added this pull request to the merge queue Jul 1, 2024
Merged via the queue into develop with commit af5eb82 Jul 1, 2024
17 checks passed
@prestonvanloon prestonvanloon deleted the electra-updated-get_next_sync_committee_indices branch July 1, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants