Fix mockgen sh #14068
Merged
Fix mockgen sh #14068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
May 31, 2024
| @@ -27,8 +27,7 @@ done | |||
| # github.com/prysmaticlabs/prysm/v5/validator/client/iface | |||
| # -------------------------------------------------------- | |||
| iface_mocks=( | |||
| "$iface_mock_path/beacon_chain_client_mock.go BeaconChainClient" | |||
| "$iface_mock_path/prysm_beacon_chain_client_mock.go PrysmBeaconChainClient" | |||
There was a problem hiding this comment.
Instead of removing this, we should generate a mock for PrysmChainClient
"$iface_mock_path/prysm_chain_client_mock.go PrysmChainClient"
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
terencechain
force-pushed
the
fix-mockgen-sh
branch
from
14b655d
to
2092d36
Compare
terencechain
force-pushed
the
fix-mockgen-sh
branch
from
2092d36
to
a51cee6
Compare
james-prysm
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes mockgen sh
BeaconChainClientwas renamed toChainClientbut never reflected for mockgenmockgen.shto ensure everything passed