Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more validator client cleanup #14048

Merged
merged 11 commits into from
May 31, 2024
Merged

One more validator client cleanup #14048

merged 11 commits into from
May 31, 2024

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented May 27, 2024

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

  • fix some package and file names
  • remove Get/List from interface method names
  • fix code inspection issues

@rkapka rkapka requested a review from a team as a code owner May 27, 2024 10:35
@rkapka rkapka force-pushed the more-validator-cleanup branch 3 times, most recently from 5d2eca5 to cba0410 Compare May 27, 2024 10:56
func (c *beaconApiValidatorClient) GetDuties(ctx context.Context, in *ethpb.DutiesRequest) (*ethpb.DutiesResponse, error) {
return wrapInMetrics[*ethpb.DutiesResponse]("GetDuties", func() (*ethpb.DutiesResponse, error) {
func (c *beaconApiValidatorClient) Duties(ctx context.Context, in *ethpb.DutiesRequest) (*ethpb.DutiesResponse, error) {
return wrapInMetrics[*ethpb.DutiesResponse]("Duties", func() (*ethpb.DutiesResponse, error) {
return c.getDuties(ctx, in)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the get from these as well? Since the idea is the same despite not being exported

Suggested change
return c.getDuties(ctx, in)
return c.duties(ctx, in)

@rkapka rkapka added Ready For Review A pull request ready for code review Cleanup Code health! labels May 29, 2024
# Conflicts:
#	testing/validator-mock/node_client_mock.go
#	validator/client/beacon-api/json_rest_handler.go
#	validator/client/grpc-api/grpc_validator_client.go
#	validator/client/iface/validator_client.go
@rkapka rkapka added this pull request to the merge queue May 31, 2024
Merged via the queue into develop with commit 3ab759e May 31, 2024
16 of 17 checks passed
@rkapka rkapka deleted the more-validator-cleanup branch May 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants