eip-7251: Updated initiate_validator_exit #13974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
force-pushed
the
eip-7251-initiate-validator-exit
branch
from
c5413df
to
38008b1
Compare
james-prysm
reviewed
May 9, 2024
| if churn >= currentChurn { | ||
| exitQueueEpoch, err = exitQueueEpoch.SafeAdd(1) | ||
| // Compute exit queue epoch. | ||
| if s.Version() <= version.Deneb { |
There was a problem hiding this comment.
we have been doing s.Version() < version.Electra in most other places
prestonvanloon
force-pushed
the
eip-7251-initiate-validator-exit
branch
from
38008b1
to
93266d0
Compare
eip-7251: tests for initiate_validator_exit
prestonvanloon
force-pushed
the
eip-7251-initiate-validator-exit
branch
from
93266d0
to
cb28e0b
Compare
james-prysm
reviewed
May 9, 2024
| @@ -43,49 +45,65 @@ func MaxExitEpochAndChurn(s state.BeaconState) (maxExitEpoch primitives.Epoch, c | |||
|
|
|||
| // InitiateValidatorExit takes in validator index and updates | |||
| // validator with correct voluntary exit parameters. | |||
| // Note: As of Electra, the exitQueueEpoch and churn parameters are unused. | |||
ErnestK
pushed a commit
to ErnestK/prysm
that referenced
this pull request
May 19, 2024
…3974) eip-7251: tests for initiate_validator_exit
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
eip-7251: tests for initiate_validator_exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Extracted from #13903
Which issues(s) does this PR fix?
Tracking @ #13849
Other notes for review
See: https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.2/specs/electra/beacon-chain.md#updated--initiate_validator_exit