Return syncing status when node is optimistic #13875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Apr 12, 2024
| return | ||
| } | ||
| if s.SyncChecker.Syncing() || s.SyncChecker.Initialized() { |
There was a problem hiding this comment.
Initialized doesn't say much. It is cleaner to just remove it.
rkapka
force-pushed
the
optimistic-node-health
branch
from
fcb7d95
to
06f00da
Compare
nisdas
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Our implementation of the https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Node/getHealth endpoint currently returns 200 when the node is optimistically synced. This might be misleading to node operators who will deem the node as ready to serve validators.