Improve logging. #13708
Merged
Improve logging. #13708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
force-pushed
the
fix-logs
branch
2 times, most recently
from
30c95a5
to
ab8ed56
Compare
potuz
reviewed
Mar 8, 2024
beacon-chain/p2p/service.go
Outdated
| "activePeers": len(s.peers.Active()), | ||
| "inbound": len(s.peers.InboundConnected()), | ||
| "outbound": len(s.peers.OutboundConnected()), | ||
| "active": len(s.peers.Active()), |
There was a problem hiding this comment.
This may break some scripts, any reasons to change? Although I agree it's a change for the better.
There was a problem hiding this comment.
No reason appart redundancy and consistency.
The log is:
INFO p2p: Peer summary activePeers=10 inbound=0 outbound=9
We already know that peers are the items being active since the log itself if Peer summary.
Also to be consistent, we would have either:
INFO p2p: Peer summary activePeers=10 inboundPeers=0 outboundPeers=9
or
INFO p2p: Peer summary active =10 inbound=0 outbound=9
But ok for scripts break, I'll fix.
potuz
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
This PR has two commits: