Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle special case of batch size=1 #13646

Merged
merged 2 commits into from
Mar 15, 2024
Merged

handle special case of batch size=1 #13646

merged 2 commits into from
Mar 15, 2024

Conversation

kasey
Copy link
Contributor

@kasey kasey commented Feb 21, 2024

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?
Fixes an edge case where backfill batch size of 1 leads to backfill status being updated while finalized index is not updated.

@kasey kasey requested a review from a team as a code owner February 21, 2024 17:14
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Do we want to add a unit test?

@kasey kasey added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit f343333 Mar 15, 2024
17 checks passed
@kasey kasey deleted the fix-batch-size-1 branch March 15, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants