Switch gomock library #13639
Merged
Switch gomock library #13639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested changes
Feb 21, 2024
prestonvanloon
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Please run ./hack/update-mockgen.sh again. Looks like some extra stuff as @rkapka mentioned
rkapka
previously approved these changes
Feb 21, 2024
prestonvanloon
previously approved these changes
Feb 21, 2024
rkapka
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
I had to install gomock to regenerate some files and it turns out that the repo we are currently using is no longer being maintained and was recommending using go.uber.org/mock instead.
This PR updates all our dependencies and generated files to use this instead.
Other notes for review