Backfill start after init-sync at head #13623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
approved these changes
Feb 15, 2024
kasey
force-pushed
the
backfill-wait-initsync
branch
from
d90ef79
to
e9a55b6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Backfill doesn't cooperate with init-sync to preserve rate limit capacity. Making backfill requests concurrently with init-sync requests could be causing peers serving init-sync requests to give init-sync rate limit errors, especially on goerli where some prysm nodes are running with excessively low blob batch limits. We should prioritize init-sync over backfill at node startup so the node can get up to head as soon as possible.
And so
This PR adds a step to backfill service startup to block on the signal that other services use to wait for init-sync to catch up to head for the first time. Backfill won't spawn the worker pool or begin computing batches until node begins gossip syncing at head.