removing show deposit data flag #13618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Feb 14, 2024
prestonvanloon
approved these changes
Feb 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
meehow
added a commit
to meehow/prysm
that referenced
this pull request
May 5, 2024
terencechain
pushed a commit
to meehow/prysm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
deposit data shouldn't be displayed through cli, it should be provided when creating the keystores and should be stored safely. this data has not been displayed for years but the flag still existed. The flag has been removed in this pr and is used for one-time commands to list validator accounts. there shouldn't be any disruption with regular run service
related #13609