Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slasher: Fix surrounded votes false negative #13612

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

nalepae
Copy link
Contributor

@nalepae nalepae commented Feb 13, 2024

Please read commit by commit, with commit messages.

What type of PR is this?
Bug fix.

What does this PR do? Why is it needed?
Currently, the slasher is unable to detect surrounded votes if corresponding attestations are received in different batches.
This PR fixes this issue.

Which issues(s) does this PR fix?
Fixes #13591

…atchSize`.

Before this commit, `TestStore_LastEpochWrittenForValidators` works if `validatorsCount <= 10000`
and stops working if `validatorsCount > 10000`.
@nalepae nalepae marked this pull request as ready for review February 13, 2024 09:36
@nalepae nalepae requested a review from a team as a code owner February 13, 2024 09:36
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup and finding, glad that the test was uncommented as well

@nalepae nalepae added this pull request to the merge queue Feb 13, 2024
Merged via the queue into develop with commit 3d13c69 Feb 13, 2024
17 checks passed
@nalepae nalepae deleted the slasher-surrounded-votes-13591 branch February 13, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slasher: False negative for surrounded votes
2 participants