Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: clear blobs when using --clear-db or --force-clear-db #13605

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Feb 9, 2024

What type of PR is this?

Feature

What does this PR do? Why is it needed?

When a user sets --clear-db or --force-clear-db they are expecting to erase all of Prysm's long
term data. Understandably, the users may expect that blobs are cleared as well.

Which issues(s) does this PR fix?

Fixes #13547

Other notes for review

Also put a Close() call in the ClearDB() method as every caller was closing the DB anyway. It should be safe to do this. I verified at runtime that this worked OK

@nisdas nisdas added this pull request to the merge queue Feb 10, 2024
Merged via the queue into develop with commit 03068ba Feb 10, 2024
17 checks passed
@nisdas nisdas deleted the clear-blobs branch February 10, 2024 04:16
@prestonvanloon prestonvanloon self-assigned this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear DB parameters do not delete Blob-directory
2 participants