Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mainnet fork epoch #13601

Merged
merged 8 commits into from
Feb 16, 2024
Merged

add mainnet fork epoch #13601

merged 8 commits into from
Feb 16, 2024

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Feb 9, 2024

Blobs are coming.

ethereum/consensus-specs#3597

@potuz potuz requested a review from a team as a code owner February 9, 2024 14:29
@prestonvanloon
Copy link
Member

Tests are failing since we use the consensus_specs repo to verify our configs are correct and we've only updated eth-networks

@prestonvanloon
Copy link
Member

Waiting for ethereum/consensus-specs#3598

prestonvanloon
prestonvanloon previously approved these changes Feb 15, 2024
@@ -23,7 +23,10 @@ const (
mainnetAltairForkEpoch = 74240 // Oct 27, 2021, 10:56:23am UTC
// Bellatrix Fork Epoch for mainnet config.
mainnetBellatrixForkEpoch = 144896 // Sept 6, 2022, 11:34:47am UTC
mainnetDenebForkEpoch = math.MaxUint64
// Capella Fork Epoch for mainnet config.
mainnetCapellaForkEpoch = 194048 // April 12, 2023, 22:27:35 UTC
Copy link
Contributor

@saolyn saolyn Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, for consistency or at least appearing the same as the above comments, it should be:

Suggested change
mainnetCapellaForkEpoch = 194048 // April 12, 2023, 22:27:35 UTC
mainnetCapellaForkEpoch = 194048 // Apr 12, 2023, 22:27:35pm UTC

// Capella Fork Epoch for mainnet config.
mainnetCapellaForkEpoch = 194048 // April 12, 2023, 22:27:35 UTC
// Deneb Fork Epoch for mainnet config.
mainnetDenebForkEpoch = 269568 // March 13, 2024, 13:55:35 UTC
Copy link
Contributor

@saolyn saolyn Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

Suggested change
mainnetDenebForkEpoch = 269568 // March 13, 2024, 13:55:35 UTC
mainnetDenebForkEpoch = 269568 // Mar 13, 2024, 13:55:35pm UTC

@prestonvanloon prestonvanloon added this pull request to the merge queue Feb 16, 2024
Merged via the queue into develop with commit 92303b6 Feb 16, 2024
17 checks passed
@prestonvanloon prestonvanloon deleted the deneb_fork_epoch branch February 16, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants