Validate Range Availibility #13587
Merged
Validate Range Availibility #13587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
kasey
requested changes
Feb 6, 2024
| return false, err | ||
| } | ||
| cpr, err := s.cfg.beaconDB.OriginCheckpointBlockRoot(ctx) | ||
| if errors.Is(err, db.ErrNotFoundOriginBlockRoot) { |
There was a problem hiding this comment.
Could you please use backfill service AvailableBlocker interface instead? You can initialize it exactly like stategen: https://github.com/prysmaticlabs/prysm/blob/develop/beacon-chain/node/node.go#L550
kasey
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Nodes which are undergoing backfill or have checkpoint synced need to be aware of their current backfill status before returning responses to other peers. Rather than returning an empty batch, an error indicating that the resource is unavailable is correct according to the p2p specification.
Which issues(s) does this PR fix?
N.A
Other notes for review