validator exiting ux improvement, add a log and update size for promptui #13542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
Jan 29, 2024
Comment on lines
+45
to
+46
| if len(pubKeyStrings) > 5 { | ||
| log.Warnf("there are more than %d potential public keys to exit, please consider using the --%s or --%s flags", 5, flags.VoluntaryExitPublicKeysFlag.Name, flags.ExitAllFlag.Name) |
There was a problem hiding this comment.
5 feels like a bit of a magic number, is there a constant we can use for this?
There was a problem hiding this comment.
It's a magic number in that library we are using if you look in that promptui not sure if it changes on updates
saolyn
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
a size was not passed for promptui resulting in only 5 public keys displayed while using voluntary exits, this PR adds a log to print recommendations and allows the user to use promptui with more than 5 keys.