Fetch unaggregated atts in GetAggregateAttestation
#13533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
rkapka
commented
Jan 26, 2024
| return | ||
| } | ||
| if bytes.Equal(root[:], attDataRoot) { | ||
| if bestMatchingAtt == nil || len(att.AggregationBits) > len(bestMatchingAtt.AggregationBits) { |
There was a problem hiding this comment.
The extracted function doesn't have the bits check because they can't be different - otherwise the root wouldn't match.
james-prysm
reviewed
Jan 26, 2024
| @@ -51,53 +51,67 @@ func (s *Server) GetAggregateAttestation(w http.ResponseWriter, r *http.Request) | |||
| return | |||
| } | |||
|
|
|||
| if err := s.AttestationsPool.AggregateUnaggregatedAttestations(ctx); err != nil { | |||
There was a problem hiding this comment.
note: found out this was just wrong before in the gRPC implementation of GetAggregateAttestation, instead we should be looking at the business logic of SubmitAggregateSelectionProof in v1alpha1
james-prysm
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
While running the REST VC, many times signature aggregation failed with the
Could not get matching attestationerror, even though the aggregator did send a matching attestation for the slot. In the implementation of the same functionality in v1alpha1 we don't aggregate first, but we try to find a matching aggregated att first, and then an unaggregated one as a fallback. After implementing the same behavior, there are no more errors observed.