Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator client: remove blob signing #13169

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

terencechain
Copy link
Member

Part of #13155

This PR removes the blob signing code from the validator client code and eliminates the web3signer endpoint. The Protobuf object SignedBeaconBlockAndBlobsDeneb still exists; it will be addressed in the next PR, which will update the proposer RPC server.

@terencechain terencechain added the Ready For Review A pull request ready for code review label Nov 3, 2023
@terencechain terencechain self-assigned this Nov 3, 2023
@terencechain terencechain requested a review from a team as a code owner November 3, 2023 16:02
@terencechain terencechain added the Deneb PRs or issues for the Deneb upgrade label Nov 3, 2023
@james-prysm
Copy link
Contributor

i also opened an issue here ethereum/remote-signing-api#7 for removing it as it's not needed.

@terencechain terencechain merged commit 12f7143 into develop Nov 3, 2023
16 of 17 checks passed
@terencechain terencechain deleted the validator-rm-blob-signing branch November 3, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb PRs or issues for the Deneb upgrade Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants