Validator client builder support #10749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
reviewed
Jun 6, 2022
| @@ -980,7 +983,8 @@ func (v *validator) UpdateProposerSettings(ctx context.Context, km keymanager.IK | |||
| for _, request := range registerValidatorRequests { | |||
| // calls beacon API but used for custom builders | |||
| if err := SubmitValidatorRegistration(ctx, v.validatorClient, v.node, km.Sign, request); err != nil { | |||
| return errors.Wrap(err, fmt.Sprintf("failed to register validator for custom builder for %s", hexutil.Encode(request.Pubkey))) | |||
| // log the error and keep going | |||
| log.Warnf("failed to register validator for custom builder for %s, error: %v ", hexutil.Encode(request.Pubkey), err) | |||
There was a problem hiding this comment.
I thought the plan was to make all requests (so that a bad request doesn't ruin it for the rest), but at the end of the method return an error if any of the requests failed. @terencechain if some of the requests fail, should this method return an error?
There was a problem hiding this comment.
Updated to address this, lt me know if this works , unit test added
kasey
reviewed
Jun 6, 2022
validator/client/validator.go
Outdated
| if len(failedRegistrationPubkeys) != 0 { | ||
| return errors.Errorf("Register Validator requests failed for the following publickeys: %v", failedRegistrationPubkeys) | ||
| if failedRegistrationCount != 0 { | ||
| return errors.Errorf("Register validator requests failed %v times out of %v requests", failedRegistrationCount, len(registerValidatorRequests)) |
There was a problem hiding this comment.
nitpick: it's nice to use the typed string formatters (eg %d for numbers, %s for strings) rather than %v where possible, because linters understand them and will complain when types are misaligned.
kasey
previously approved these changes
Jun 6, 2022
kasey
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
related to #10593
What does this PR do? Why is it needed?
This PR builds on top of #10669
This PR provides capabilities for users to define fee recipients and gaslimit information on their corresponding validator public keys and send them to the beacon node, which will in turn call the builder APIs. These user-defined configurations are important for custom builders to distribute funds correctly and are signed by the validator key for authenticity. The information used here is similar to the prepare_beacon_proposer APIs which are sent to the execution engine, the register validator API proxies to the builder APIs.
Please refer to the corresponding PRs for additional information
ethereum/builder-specs#2
https://github.com/ethereum/beacon-APIs/pull/209/files
includes
does not include