Move "Enter a password" cmd instructions to shared/cmd #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
May 3, 2020
| @@ -42,3 +43,16 @@ func ConfirmAction(actionText string, deniedText string) (bool, error) { | |||
|
|
|||
| return confirmed, nil | |||
| } | |||
|
|
|||
| func EnterPassword() (string, error) { | |||
| @@ -42,3 +43,16 @@ func ConfirmAction(actionText string, deniedText string) (bool, error) { | |||
|
|
|||
| return confirmed, nil | |||
| } | |||
|
|
|||
| func EnterPassword() (string, error) { | |||
There was a problem hiding this comment.
This also is a good unit test candidate
There was a problem hiding this comment.
+1 unit test would be good for this
There was a problem hiding this comment.
Writing a test for terminal.ReadPassword is rather complicated, made a tracking issue at #5749
nisdas
reviewed
May 4, 2020
| log.Fatalf("Could not read account password: %v", err) | ||
| return path, passphrase, err | ||
| log.Fatal(err) | ||
| return path, enteredPassphrase, err |
There was a problem hiding this comment.
no point of returning the result here, when you have a fatal log above
There was a problem hiding this comment.
Yeah this is duplicated several times in the validator client, was gonna make another PR making sure it's either handled or returned, never both.
Codecov Report
@@ Coverage Diff @@
## master #5724 +/- ##
===========================================
- Coverage 54.76% 40.20% -14.57%
===========================================
Files 313 301 -12
Lines 26485 25154 -1331
===========================================
- Hits 14504 10112 -4392
- Misses 9894 13184 +3290
+ Partials 2087 1858 -229 |
…o move-pass-to-cmd
rauljordan
previously approved these changes
May 5, 2020
terencechain
reviewed
May 5, 2020
shared/cmd/helpers.go
Outdated
|
|
||
| // EnterPassword queries the user for their password through the terminal, in order to make sure it is | ||
| // not passed in a visible way to the terminal. | ||
| // TODO(#5749) This function is untested, would be a good candidate for unit test. |
There was a problem hiding this comment.
Suggested change
| // TODO(#5749) This function is untested, would be a good candidate for unit test. | |
| // TODO(#5749) This function is untested, would be a good candidate for unit test. |
rauljordan
previously approved these changes
May 5, 2020
terencechain
reviewed
May 5, 2020
terencechain
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for validator client
This PR moves the CMD "Enter password" to its own function under shared/cmd, it will be reused in a future PR so might as well relocate it.
Testing
terminal.ReadPasswordis rather complicated so I've made a tracking issue for it #5749