Fix server side beacon blocks by range (#4046)

prysmaticlabs · Nov 19, 2019 · 3f6435a · 3f6435a
1 parent 64b69d9
commit 3f6435a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/beacon-chain/sync/rpc_beacon_blocks_by_range.go b/beacon-chain/sync/rpc_beacon_blocks_by_range.go
@@ -26,7 +26,7 @@ func (r *RegularSync) beaconBlocksByRangeRPCHandler(ctx context.Context, msg int
 	m := msg.(*pb.BeaconBlocksByRangeRequest)
 
 	startSlot := m.StartSlot
-	endSlot := startSlot + (m.Step * m.Count)
+	endSlot := startSlot + (m.Step * (m.Count-1))
 
 	span.AddAttributes(
 		trace.Int64Attribute("start", int64(startSlot)),

diff --git a/beacon-chain/sync/rpc_beacon_blocks_by_range_test.go b/beacon-chain/sync/rpc_beacon_blocks_by_range_test.go
@@ -27,8 +27,8 @@ func TestBeaconBlocksRPCHandler_ReturnsBlocks(t *testing.T) {
 
 	req := &pb.BeaconBlocksByRangeRequest{
 		StartSlot: 100,
-		Step:      4,
-		Count:     100,
+		Step:      64,
+		Count:     16,
 	}
 
 	// Populate the database with blocks that would match the request.