Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AcessoCard fails if user is foreigner #16

Closed
3 tasks done
jonasmalacofilho opened this issue Jan 11, 2018 · 3 comments
Closed
3 tasks done

AcessoCard fails if user is foreigner #16

jonasmalacofilho opened this issue Jan 11, 2018 · 3 comments

Comments

@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Jan 11, 2018

Despite TpCliente accepting both nationals and foreigners, any attempt to actually request as a foreigner fails.

This was triggered once by a real user (might have been an error, but probably not) and another time by me, testing it with my portuguese documents.

Note: the user request would have failed anyway, since it failed to correctly set the document type to passport (despite all other fields clearly indicating that it was indeed a passport).

To do:

  • report this to Acesso and Belcorp
  • change our error type from permanent to user/data (to show the error message)
  • add translation to this error message
  • show informative error message (deployed in v1.1.4)
  • remove the field from the UI, since right now it's at best useless (deployed in v1.1.4)
@jonasmalacofilho
Copy link
Member Author

jonasmalacofilho commented Jan 11, 2018

Disabled recovery for the two requests with:

UPDATE CardRequest SET queued = 0 WHERE requestId in (
    '2c894c1db009b65b98054053edbd423e1568c1f136092bf004a4cae25fd21a13',
    '518a44177b3adb350c2be2ca930b1afa3e99bd4eb37109e48c2d555cbfe365fa');

Might need to re-enable once the system can show better errors for them.

@jonasmalacofilho
Copy link
Member Author

jonasmalacofilho commented Jan 12, 2018

Another failed request had to be removed from future recovery:

UPDATE CardRequest SET queued = 0 WHERE requestId in (
    '7b303ee22f07bafc9ef5170c01fbd3d1e37cf56196366e068831159c4cc8f6cb');

@jonasmalacofilho
Copy link
Member Author

Closing after v1.1.4 (better error message and field removed from the UI) and report to felipe/maurílio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant