Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses are incorrectly filled from CEPs, sometimes #13

Closed
jonasmalacofilho opened this issue Jan 9, 2018 · 1 comment
Closed

Addresses are incorrectly filled from CEPs, sometimes #13

jonasmalacofilho opened this issue Jan 9, 2018 · 1 comment
Labels
bug critical

Comments

@jonasmalacofilho
Copy link
Member

TL;DW: Webmania and/or Correios send us crap. Currently, we fill the fields with such crap, and even forbid the user to change/fix some of this crap.
jonasmalacofilho added a commit that referenced this issue Jan 9, 2018
@jonasmalacofilho
Trim off extra UF details returned by Correios (see #13)
9152eaa 
Webmania returns the same data that the official Correios website shows.

Indeed, in some cases, it shows things like `PA - Povoado` and `BA -
Distrito`.  The solution is to trim off these extra details that confuse
Acesso Card.

All other instances of UF or City errors are either user errors or
Acesso Card errors; the latter doesn't know about Parati/RJ or
Camaragibe/PE.
@jonasmalacofilho
Copy link
Member Author

Fix deployed in v1.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasmalacofilho