Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

don't require go.sum in go-check workflow #74

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

marten-seemann
Copy link
Contributor

Fixes #73.

If go.mod doesn't contain any dependencies, it's not necessary to have a go.sum file.

Unfortunately, this change will trigger a PR in all repos that we've deployed to so far.

If go.mod doesn't contain any dependencies, it's not necessary to have a go.sum
file.
@marten-seemann
Copy link
Contributor Author

Waiting for @mvdan's approval before merging. He's had valuable input for bash and git in the past.

Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure tidy always adds a go.sum these days, even if it's empty. I assume this is about not failing in cp go.sum go.sum.orig if the file doesn't exist in the main branch yet.

@marten-seemann
Copy link
Contributor Author

I assume this is about not failing in cp go.sum go.sum.orig if the file doesn't exist in the main branch yet.

That's correct.

I'm pretty sure tidy always adds a go.sum these days, even if it's empty.

It doesn't.

@marten-seemann marten-seemann merged commit 241a684 into master Apr 22, 2021
@marten-seemann marten-seemann deleted the allow-no-go-sum-in-go-check branch April 22, 2021 09:30
@mvdan
Copy link
Contributor

mvdan commented Apr 22, 2021

It doesn't.

Huh, you're right, I'm not sure where I got that idea from.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-check workflow fails if the repo doesn't have a go.sum
3 participants