New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect RPCImplCallback type declaration #767

Closed

rossenassenov opened this issue Apr 19, 2017 · 1 comment

rossenassenov commented Apr 19, 2017

protobuf.js version: 6.7.1

The current type declaration for RPCImplCallback leads to compile errors in TypeScript in strictNullChecks mode:

type RPCImplCallback = (error: Error, response?: Uint8Array) => void;

the "error" param should be optional:

type RPCImplCallback = (error?: Error, response?: Uint8Array) => void;

I opened a PR: #766

Member

dcodeIO commented Apr 20, 2017

Should be fixed in 23f4b99

dcodeIO closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment