Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting >>> interface Units$Properties in .d.ts files now #721

Closed
ehallander9591 opened this issue Mar 23, 2017 · 2 comments
Closed

Getting >>> interface Units$Properties in .d.ts files now #721

ehallander9591 opened this issue Mar 23, 2017 · 2 comments

Comments

@ehallander9591
Copy link

protobuf.js version:

I pulled the latest to get the enum fix you took care of today, and this showed up in my .d.ts files.

I reverted back and it would seem the generated .d.ts had class definitions, and now they are all interface definitions and all interface definitions contain '$Properties' appended to the interface

        /**
         * Properties of an Units.
         * @typedef mpxs.model.Units$Properties
         * @type Object
         * @property {Array.<mpxs.model.Unit>} [unit] Units unit.
         * @property {number} [planTimeOffset] Units planTimeOffset.
         */
        interface Units$Properties {
            unit?: mpxs.model.Unit[];
            planTimeOffset?: number;
        }
        /**
         * Constructs a new Units.
         * @exports mpxs.model.Units
         * @constructor
         * @param {Object} [properties] Properties to set
         */
        class Units {

and all the class details
}
<please paste the stack trace of the error if applicable>
@dcodeIO
Copy link
Member

dcodeIO commented Mar 23, 2017

This is discussed here: #717

@ehallander9591
Copy link
Author

I suspect there is still work going on in the issue and that was what my colleague was talking about when he asked me if I had been following the talk about the typescript changes. I will check back and try to monitor what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants