Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings: JSONConversionOptions required fields should be optional #598

Closed
paralin opened this issue Dec 30, 2016 · 0 comments
Closed

Typings: JSONConversionOptions required fields should be optional #598

paralin opened this issue Dec 30, 2016 · 0 comments

Comments

@paralin
Copy link

paralin commented Dec 30, 2016

Here: https://github.com/dcodeIO/protobuf.js/blob/master/types/protobuf.js.d.ts#L134

And a few other places in the file - fields on that options object should be optional - fieldsOnly?: boolean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paralin