Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for an optional semicolon where there is an optional comma in parseOptionValue #1571

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

jeffory-orrok
Copy link
Contributor

@jeffory-orrok jeffory-orrok commented Mar 25, 2021

Fixes #1569.

This is to conform with behavior found in text_format.cc

    // For historical reasons, fields may optionally be separated by commas or
    // semicolons.
    TryConsume(";") || TryConsume(",");

@alexander-fenster alexander-fenster changed the title allow for an optional semicolon where there is an optional comma in parseOptionValue fix: allow for an optional semicolon where there is an optional comma in parseOptionValue Apr 29, 2021
@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster merged commit af1b449 into protobufjs:master Apr 29, 2021
@jeffory-orrok
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal name ';' when parsing the rhs of an option assignment that is not a simple strLit
2 participants