Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Reset contribution mode #31

Open
codeliner opened this issue Jul 4, 2023 · 2 comments
Open

[Infra] Reset contribution mode #31

codeliner opened this issue Jul 4, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request infrastructure
Milestone

Comments

@codeliner
Copy link
Contributor

When being in contribution mode (executed prepare-contribution) it's not that easy to reset the system after working on a topic. It's because generated files are ignored by git, so you cannot simply do a rollback using it.

What we could use instead is a script that deletes all files ignored by git

We should restrict deletion of ignored files to the packages, data, dist and tmp directories and for example not delete node modules.

@codeliner codeliner added the enhancement New feature or request label Jul 4, 2023
@codeliner codeliner added this to the Phase#1 milestone Jul 4, 2023
@kaitorched kaitorched self-assigned this Jul 26, 2023
@kaitorched
Copy link

@codeliner git clean -dfX data/ packages/ dist/ tmp/ works nicely. Of course, then the server refreshes and throws errors because of missing registry files.

I'm running the create-registry-files.ts right afterwards, so we have all them regenerated, but somehow the server still thinks they are missing. This is easily resolved by stopping the server process and npm run serve again, but I'd like to find a solution where this is not necessary or happens automatically.

Is there a way to trigger a restart of the server from command line (i.e. inside my npm run reset-contribution call)? Or make it re-scan all files, so the errors go away?

@codeliner
Copy link
Contributor Author

Good news @kaitorched
I think the restart problem is related to this issue here ,too: #32

I also recognized that the watch mode sometimes has trouble with too many changes at once. The server tries to restart, runs into a typescript compiler error and is not able to recover from it.

In case of resetting the contribution mode it's not a big deal, because developers can deal with it.
But #32 is a real problem, because non-developers will have more trouble figuring out how to recover from such a situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants