Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong include directories #292

Open
robiwano opened this issue Jul 8, 2023 · 2 comments
Open

Wrong include directories #292

robiwano opened this issue Jul 8, 2023 · 2 comments

Comments

@robiwano
Copy link

robiwano commented Jul 8, 2023

The include directories are set here: https://github.com/projectNe10/Ne10/blob/master/modules/CMakeLists.txt#L363C22-L363C22

That doesn't work with Ne10 used as submodule or via FetchContent, as PROJECT_SOURCE_DIR is the directory of the project USING Ne10, not Ne10 itself.

target_include_directories(NE10 PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/inc)

should be used in top-level CMakeLists.txt instead.
@peter-toft-greve
Copy link

@robiwano to me it looks like that Ne10 no longer is maintained

@robiwano
Copy link
Author

@robiwano to me it looks like that Ne10 no longer is maintained

Yup, looks like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robiwano @peter-toft-greve