Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parser test labels #799

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

mertovun
Copy link
Contributor

  • swaps misordered label values

@kblaschke
Copy link
Member

The tests are actually labeled correctly. There's a misleading comment in the first of the two test cases, which might give that impression. That should be deleted, but the tests should keep their respective names.

Copy link
Member

@kblaschke kblaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the labels as-is, but either remove or fix this comment:

// Lines with empty key should be ignored

@mertovun mertovun requested a review from kblaschke April 18, 2024 20:26
Copy link
Member

@kblaschke kblaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now it's both correct and no longer confusing 😄

@kblaschke kblaschke merged commit ac77498 into projectM-visualizer:master Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants