-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trivial] chip-tool did not have version number or git hash in cli command #34067
Comments
The trick is to decide what version to expose here ... current version command line handling prints out hard-coded text I believe, which is only useful among manjor versions (which we probably could change), however that also creates churn (keep updating the version file). To avoid churn, we had various requests to use The closest equivalent is defining an argument and allowing build systems to override it (and builds system may choose to take the extra time to figure out a good tag). |
@resghst Where is the chip-tool coming from whose version you want to know? Understanding that will make it easier to figure out how best to address this. |
Sometimes, I built the chip-tool a few months ago. I only leave the chip-tool bin file, so I can not easily get the chip-tool version. For instance, the chip-tool builds from:
I holp chip-tool version command will show: master-v1.3.0.0-b63c271 Thanks reply, @bzbarsky-apple @andy31415 |
I think only project-chip git-hash will fine |
@resghst Build it into a directory whose name is the SHA? |
for example, the following command can control the node 1 endpoint 1. |
Type
Other
Explanation
holp the chip-tool can add chip-tool --version or chip-tool version command.
Platform
raspi
Platform Version(s)
No response
Testing
Manually tested with SDK
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: