Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type-safe Invasion status #27

Open
programaker opened this issue Oct 9, 2019 · 1 comment
Open

Type-safe Invasion status #27

programaker opened this issue Oct 9, 2019 · 1 comment
Labels
refactoring Improve things without change behavior

Comments

@programaker
Copy link
Owner

Draft of the idea - https://scastie.scala-lang.org/programaker/QzbOoPCxTIuCvlXhWyUPBA/8

GameProgress.start should accept only defeated Invasions.
defeated flag will be removed and replaced by type checking.
@programaker programaker added refactoring Improve things without change behavior in progress Task is being worked on and removed in progress Task is being worked on labels Oct 9, 2019
@programaker
Copy link
Owner Author

To make it really safe, GameProgress changes proposed in #4 are necessary, otherwise we can't handle Invasions with different statuses inside the same GameProgress. We'll need a Start game progress with only Active Invasions and a InBattle progress with mixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Improve things without change behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@programaker