Add PDCClient tests

[hluk]

No description provided.

[hluk]

Keeping compatibility with Python 2.6 sucks - still have to fix some tests.

[xiangge]

Yes, I think we can consider to remove the 2.6 test in the future and add update the 3.3 to 3.5.

1. And also I think in the case we should include the attr "_" to add a "/" in the end of the uri.
2. And we should also add the getitem way in each of the test function, like client["cpes"].

[hluk]

While adding tests for rest of the API I found few issues. Fixes are included.

1. And also I think in the case we should include the attr "_" to add a "/" in the end of the uri.

Added.

2. And we should also add the getitem way in each of the test function, like client["cpes"].

This is already tested on few places. I want to have simple and small test methods for testing just specific part of API.

[hugovk]

Here's the pip installs for pdc-client from PyPI for the last month -- a single 2.6 and no 3.3 (both are EOL):

$ pypinfo --percent --pip pdc-client pyversion
python_version percent download_count
-------------- ------- --------------
2.7              63.9%            991
3.6              20.6%            319
3.5              12.5%            194
3.4               2.9%             45
2.6               0.1%              1

By the way, you could add both 3.5 and 3.6 to Travis etc. More reasons for dropping old ones:

2.6

• Unsupported since 2013-10-29
• https://snarky.ca/stop-using-python-2-6/
• http://www.curiousefficiency.org/posts/2015/04/stop-supporting-python26.html
• http://www.python3statement.org
• Current pip 9 deprecates Python 2.6 support, pip 10 won't support it (Drop support for Python 2.6? pypa/pip#3955)
• Not much PyPI traffic (June 2016) Deprecate/Drop Support for Python 3.3? pypa/pip#3796

3.2

• (Already dropped! :)

3.3

• Unsupported since 2017-09-29
• pip 10 will deprecate Python 3.3 support, pip 11 won't support it (Deprecate/Drop Support for Python 3.3? pypa/pip#3796)
• Very little PyPI traffic (June 2016) Deprecate/Drop Support for Python 3.3? pypa/pip#3796

[xiangge]

Is the cpe returned data in our product something like below one?
[
{
"id": 1,
"cpe": "cpe:test",
"description": "1234"
}
]

[hluk]

The mocked server returns paged response when making GET HTTP request to rest_api/v1/cpe/.

[xiangge]

So the data is like the data in db, got that, thx.

[xiangge]

And we should also add the getitem way in each of the test function, like client["cpes"].

This is already tested on few places. I want to have simple and small test methods for testing just specific part of API.

I think we can add codes here to test patch as item, not mean add more test functions.

 self.client['cpes'][1] += {'description': 'TEST1'}
 self.assertEqual(_MockPDCServerRequestHandler.last_comment, 'TEST1')

Maybe you mean self.client.cpes[1] is the case that gets resource by item "[1]"?

[hluk]

OK, I'll add that. Also patching using += for attribute would be nice.

[xiangge]

cool

[xiangge]

I just found I keep the comment there for several days, but not submit it,sorry about that...
Why github always let me submit again after I give comment ...

[simozhan]

Nice patch. Just one minor thing related to the test case

[simozhan]

I don't quite understand this case. Is this testing the Mock server setup correctly? I think other cases already cover this.

[hluk]

OK, I'll remove it. It was the first test just to verify the server is running.

[hluk]

I simplified the server code a lot (no regexps and should be easier to modify).

I also added few more tests for PUT and PATCH.

[hluk]

Test coverage for the last change

[xiangge]

If you change like this, it seems that when the response is a list, the "while true" seems not break?

[hluk]

Nice catch. Fixed and added test for this.

[xiangge]

cool

[xiangge]

So the data is like the data in db, got that, thx.

[simozhan]

Reivewed again. LGTM