This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 856
Commits on Nov 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f89ce99 - Browse repository at this point
Copy the full SHA f89ce99View commit details -
Configuration menu - View commit details
-
Copy full SHA for b502efc - Browse repository at this point
Copy the full SHA b502efcView commit details -
Fix: Add dummy advice colum to prevent Phase error
Currently, halo2 prevents the user from adding `Advice<PhaseN>` columns if no column of the previous phase was defined before. Since the first thing we need are the `Challenges` and these are placed with `Phase2` we no longer can compile the code. Therefore, a dummy column is added so that halo2 does not complain. This should be solved in the future if the challenge API polishes this.
Configuration menu - View commit details
-
Copy full SHA for fa99f2c - Browse repository at this point
Copy the full SHA fa99f2cView commit details -
feat: Port KeccakBit impl to challenge API
This introduces the challenge API inclusion into the Keccak Bit implementation. This carries 2 different challenges. one for the inputs and another for the table-exposed value. The changes consists on: 1- Swap the meta.advice_column for meta.advice_column_in(SecondPhase). 2- Replace the randomnes hardcoded now in the circuit by the Challenges. Including it in the configure and witness_generation functions. 3- Test with a custom Challenges which has a fixed value.
Configuration menu - View commit details
-
Copy full SHA for 3bb4c8d - Browse repository at this point
Copy the full SHA 3bb4c8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4da1b9 - Browse repository at this point
Copy the full SHA b4da1b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c5606 - Browse repository at this point
Copy the full SHA 66c5606View commit details -
fix: Add
extract_field
to utilsI made an effort to migrate `Part<F>` and `PartValue<F>` to use the `Value<F>` halo2 API. But since the struct doesn't implement `PartialEq` it's challenging to do it. As I do need to operate with it quite a lot. Also, there's another caveat which is that it feels really tricky to extract the byte representation from a `Value<F>`. It feels like if you're cheating to the API constrantly (using `.map()` to gain access to the underlying F so that you can do extra things with it such as decompose it into bytes). For these reasons, right now `extract_field` was added. An issue will be filled to track the tech-debt left here and pay it once we maybe we add the required functionalities to `halo2::Value<F>`.
Configuration menu - View commit details
-
Copy full SHA for cc1a21e - Browse repository at this point
Copy the full SHA cc1a21eView commit details -
update: Adapt SuperCircuit to new keccak APIs
Now that all the three keccak implementations use the challenge API, it's time to update the SuperCircuit to adapt to these new APIs.
Configuration menu - View commit details
-
Copy full SHA for d064ec9 - Browse repository at this point
Copy the full SHA d064ec9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62ed6c0 - Browse repository at this point
Copy the full SHA 62ed6c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e77a5f0 - Browse repository at this point
Copy the full SHA e77a5f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1714688 - Browse repository at this point
Copy the full SHA 1714688View commit details
Commits on Nov 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 59b6778 - Browse repository at this point
Copy the full SHA 59b6778View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70ba478 - Browse repository at this point
Copy the full SHA 70ba478View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.