Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Add PiCircuit to integration tests #1447

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

ed255
Copy link
Member

@ed255 ed255 commented Jun 1, 2023

Description

This is a very small PR. While investigating #1439 I noticed we don't have an integration test for the Public Inputs Circuit, so I just added it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@github-actions github-actions bot added crate-integration-tests Issues related to the integration-tests workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member labels Jun 1, 2023
@ed255 ed255 force-pushed the feature/integration-test-pi branch from d60adbb to 0bfad3d Compare June 1, 2023 12:04
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ed255 ed255 force-pushed the feature/integration-test-pi branch from 0bfad3d to b427201 Compare June 2, 2023 09:31
@ed255 ed255 merged commit 7715ef2 into main Jun 2, 2023
@ed255 ed255 deleted the feature/integration-test-pi branch June 2, 2023 10:29
@ed255
Copy link
Member Author

ed255 commented Jun 2, 2023

Merged with a single approval because this PR is very small and simple.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-integration-tests Issues related to the integration-tests workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants