This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Feat/CREATE Part C - bus-mapping and gadget implementation #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
KimiWu123
changed the title
KimiWu123
changed the title
4 tasks
KimiWu123
force-pushed
the
feat/create-part-c
branch
from
d23050d
to
d37a19a
Compare
github-actions
bot
removed
the
crate-mock
KimiWu123
force-pushed
the
feat/create-part-c
branch
from
d37a19a
to
6b274a1
Compare
KimiWu123
force-pushed
the
feat/create-part-c
branch
from
64a4d9f
to
a6ad558
Compare
silathdiir
reviewed
Jun 5, 2023
KimiWu123
changed the title
silathdiir
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Add small comments, others LGTM.
Hi @KimiWu123, please help resolve the fixed conversations. Seems there is no Resolve conversation button on my side. Thanks.
miha-stopar
reviewed
Jun 6, 2023
| CircuitTestBuilder::new_from_test_ctx(ctx).run(); | ||
| } | ||
|
|
||
| // RETURN or REVERT with data of [0x60; 5] |
There was a problem hiding this comment.
Can you add a short description why this particular initialization?
There was a problem hiding this comment.
The init code content doesn't matter, could put any random data. We don't really run the piece of the code.
There was a problem hiding this comment.
Yes, I thought so - perhaps just add a comment that any code would do.
| code | ||
| } | ||
|
|
||
| fn creater_bytecode( |
There was a problem hiding this comment.
Nitpick: perhaps change creater to creator?
| code.append(&bytecode! { | ||
| PUSH1(initialization_bytes.len()) // size | ||
| PUSH1(32 - initialization_bytes.len()) // length | ||
| PUSH2(23414) // value |
There was a problem hiding this comment.
Suggested change
| PUSH2(23414) // value | |
| PUSH2(23414) // value (endowment in CREATE2) |
| let gas_cost = GasCost::CREATE.expr() + memory_expansion.gas_cost() + keccak_gas_cost; | ||
| let gas_remaining = cb.curr.state.gas_left.expr() - gas_cost.clone(); | ||
| let gas_left = ConstantDivisionGadget::construct(cb, gas_remaining.clone(), 64); | ||
| let callee_gas_left = gas_remaining - gas_left.quotient(); |
miha-stopar
reviewed
Jun 7, 2023
miha-stopar
approved these changes
Jun 8, 2023
ChihChengLiang
approved these changes
Jun 9, 2023
1 task
This was referenced Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This is an updated version of #1358
This PR is actually based on top of #1425
Issue Link
#1130
Type of change
Contents
Bus mapping implementation for CREATE/CREATE2
EVM circuit's gadget for CREATE/CREATE2
How Has This Been Tested?
Tests can be found here: https://github.com/scroll-tech/zkevm-circuits/blob/2d2bfc6ccf179ade1a8d063f9586b93e5283a557/zkevm-circuits/src/evm_circuit/execution/create.rs#L678