Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

tech-debt: Re-enable end_tx tests that depended on SSTORE #1111

Closed
CPerezz opened this issue Jan 25, 2023 · 0 comments · Fixed by #1459
Closed

tech-debt: Re-enable end_tx tests that depended on SSTORE #1111

CPerezz opened this issue Jan 25, 2023 · 0 comments · Fixed by #1459
Assignees
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member good first issue Good for newcomers T-tech-debt Type: tech-debt generated or cleaned up T-test Type: test improvements

Comments

@CPerezz
Copy link
Member

CPerezz commented Jan 25, 2023

In #312 we left some tech debt as some tests for EndTx could not be done due to SSTORE not being implemented.

Now that it is, we should be able to brind them back and pay this tech debt.

See:

fn end_tx_gadget_simple() {
// TODO: Enable this with respective code when SSTORE is implemented.
// Tx with non-capped refund
// test_ok(vec![mock_tx(
// address!("0x00000000000000000000000000000000000000fe"),
// Some(27000),
// None,
// )]);
// Tx with capped refund
// test_ok(vec![mock_tx(
// address!("0x00000000000000000000000000000000000000fe"),
// Some(65000),
// None,
// )]);

@CPerezz CPerezz added crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-test Type: test improvements T-tech-debt Type: tech-debt generated or cleaned up labels Jan 25, 2023
@CPerezz CPerezz added the good first issue Good for newcomers label Feb 6, 2023
@rrtoledo rrtoledo self-assigned this Jun 2, 2023
@rrtoledo rrtoledo linked a pull request Jun 6, 2023 that will close this issue
4 tasks
rrtoledo pushed a commit that referenced this issue Jun 12, 2023
### Description

Enable tests to check if gas refund was implemented correctly (c.f. [EIP
3529](https://eips.ethereum.org/EIPS/eip-3529))

### Issue Link

Issue #1111 

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Contents

- Uncommenting and updating tests

### Rationale

Using the commented values and common values for account creation.

### How Has This Been Tested?
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member good first issue Good for newcomers T-tech-debt Type: tech-debt generated or cleaned up T-test Type: test improvements
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants