Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Remove MPT table empty row once Halo2 supports error rendering for empty regions. #1032

Closed
CPerezz opened this issue Jan 5, 2023 · 0 comments · Fixed by #1096
Closed

Remove MPT table empty row once Halo2 supports error rendering for empty regions. #1032

CPerezz opened this issue Jan 5, 2023 · 0 comments · Fixed by #1096
Assignees
@CPerezz
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-tech-debt Type: tech-debt generated or cleaned up

Comments

@CPerezz
Copy link
Member

CPerezz commented Jan 5, 2023

As pointed by @lispc in #1024 (comment), Halo2 currently has a bug which prevents it to render correctly the errors for an empty region with a ConstraintError on it.

An issue has been filled for this so that we can fix it in privacy-scaling-explorations/halo2#117. Meanwhile a new tag is not released for Halo2 with a fix, this fix will temporarily be needed.

This issue is a reminder to revert the changes added in #1024 for the MPT table once a new tag is released for halo2 with a fix.
@CPerezz CPerezz added crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-tech-debt Type: tech-debt generated or cleaned up labels Jan 5, 2023
@CPerezz CPerezz self-assigned this Jan 5, 2023
CPerezz added a commit that referenced this issue Jan 5, 2023
@CPerezz
fix: Add empty row in MPT table to prevent testing panics
78e3bac 
As pointed by @lispc in
#1024 (comment),
Halo2 currently has a bug which prevents it to render correctly the
errors for an empty region with a `ConstraintError` on it.

An issue has been filled for this so that we can fix it in
privacy-scaling-explorations/halo2#117.

Meanwhile a new tag is not released for Halo2 with a fix, this fix will
temporarily be needed and a reminder to remove it has been created in #1032
CPerezz added a commit that referenced this issue Jan 5, 2023
@CPerezz
Fix/super circuit double assign (#1024)
afb6f27 
* fix: Remove duplicate assignment of evm circuit

* fix: Remove mpt table load from StateCircuit

The table is loaded now in the SuperCircuit and the double-assignment is
removed by removing the assignment from the StateCircuit `synthesize_sub` method.

Resolves: #987

* fix: Add empty row in MPT table to prevent testing panics

As pointed by @lispc in
#1024 (comment),
Halo2 currently has a bug which prevents it to render correctly the
errors for an empty region with a `ConstraintError` on it.

An issue has been filled for this so that we can fix it in
privacy-scaling-explorations/halo2#117.

Meanwhile a new tag is not released for Halo2 with a fix, this fix will
temporarily be needed and a reminder to remove it has been created in #1032
CPerezz added a commit that referenced this issue Jan 20, 2023
@CPerezz
fix: Revert empty row inclusion in MPT table
56ae2c4 
With the new halo2_proofs release added in #1094, we no longer
need to have an empty row for the mpt table so that the error reporting
functions don't panic on finding a Region with no rows.

Resolves: #1032
@CPerezz CPerezz mentioned this issue Jan 20, 2023
Merged
CPerezz added a commit that referenced this issue Jan 21, 2023
@CPerezz
fix: Revert empty row inclusion in MPT table (#1096)
6d1ea92 
With the new halo2_proofs release added in #1094, we no longer
need to have an empty row for the mpt table so that the error reporting
functions don't panic on finding a Region with no rows.

Resolves: #1032
SuccinctPaul pushed a commit to SuccinctPaul/zkevm-circuits that referenced this issue Feb 15, 2024
@noel2004
[FEAT] precompile-sha256 (privacy-scaling-explorations#1032)
7fa17b1 
* init table16 with generic refactoring

* update cargo

* add required cfgs

* add benchmarking

* customable bench

* fmt

* config gates for sha256 circuit

* complete sha256 circuit

* induce SHA256 in bus mapping

* better challenge spec

* integrate sha256 circuit into super

* readme (wip)

* complete precompile and sha256 table

* clippies

* fmt

* better tests

* fix issues and better printing for circuit layout

* refine and fix issues

* fix digest in table16

* fix layout, clippy and fmt

* complete sha256 table

* fix rw

* fix rlc on padding

* clippy and fmt

* more tests

* test added

* sha256: update row cost per block

* update readme (wip)

* lookup input len

* enable sha256

* more tests cases

* refactoring aux data

* fmt

* fix precompile call test

* fix another callop test

* + update bench to circuit-sha256,
+ update readme

* fix vk issue, add more test

* trivial fixs

* move sha256 circuit into zkevm-circuits

* purge unused sha256 dir

* bump halo2 version

* fix blank comment
omega000133 added a commit to omega000133/zkevm-circuits that referenced this issue May 17, 2024
@omega000133
Fix/super circuit double assign (#1024)
9d577be 
* fix: Remove duplicate assignment of evm circuit

* fix: Remove mpt table load from StateCircuit

The table is loaded now in the SuperCircuit and the double-assignment is
removed by removing the assignment from the StateCircuit `synthesize_sub` method.

Resolves: #987

* fix: Add empty row in MPT table to prevent testing panics

As pointed by @lispc in
privacy-scaling-explorations/zkevm-circuits#1024 (comment),
Halo2 currently has a bug which prevents it to render correctly the
errors for an empty region with a `ConstraintError` on it.

An issue has been filled for this so that we can fix it in
privacy-scaling-explorations/halo2#117.

Meanwhile a new tag is not released for Halo2 with a fix, this fix will
temporarily be needed and a reminder to remove it has been created in privacy-scaling-explorations/zkevm-circuits#1032
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CPerezz CPerezz

Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-tech-debt Type: tech-debt generated or cleaned up
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Revert empty row inclusion in MPT table privacy-scaling-explorations/zkevm-circuits
1 participant
@CPerezz