Add basic group operation benchmarks #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
reviewed
Feb 7, 2023
benches/group.rs
Outdated
Comment on lines
12
to
13
| let a = G::generator(); | ||
| let a_affine = G::AffineExt::generator(); |
There was a problem hiding this comment.
Should we use some random value here? Since the old algorithm seems to have some optimization for adding the same point (
halo2curves/src/derive/curve.rs
Line 965 in 093c4dc
halo2curves/src/derive/curve.rs
Line 1006 in 093c4dc
benches/group.rs
Outdated
| b.iter(|| black_box(a).double()) | ||
| }); | ||
| c.bench_function(&format!("{} addition", name), move |b| { | ||
| b.iter(|| black_box(a).add(&a)) |
There was a problem hiding this comment.
Same reason as above, we might want to introduce another different value as added.
davidnevadoc
force-pushed
the
dav/group-bench
branch
from
53b9616
to
e4381e0
Compare
davidnevadoc
changed the title
han0110
reviewed
Aug 7, 2023
benches/less_than.rs
Outdated
Cargo.toml
Outdated
Comment on lines
12
to
15
| [[bench]] | ||
| name = "group" | ||
| harness = false | ||
|
|
There was a problem hiding this comment.
Perhaps we could move this to the bottom along with other [[bench]]
There was a problem hiding this comment.
Fixed in 9420284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add benchmarks for all basic group operations.
In particular we want to evaluate the impact on performance that the changes introduced by #19 have had.