Skip to content

No longer commitments to instance in transcript. #738

No longer commitments to instance in transcript.

No longer commitments to instance in transcript. #738

GitHub Actions / Clippy (beta) succeeded Oct 18, 2024 in 0s

Clippy (beta)

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 48 in halo2_backend/src/poly/query.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `blind` is never read

warning: field `blind` is never read
  --> halo2_backend/src/poly/query.rs:48:16
   |
46 | pub struct PolynomialPointer<'com, C: CurveAffine> {
   |            ----------------- field in this struct
47 |     pub(crate) poly: &'com Polynomial<C::Scalar, Coeff>,
48 |     pub(crate) blind: Blind<C::Scalar>,
   |                ^^^^^
   |
   = note: `PolynomialPointer` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis

Check warning on line 6 in halo2_backend/src/plonk/verifier/batch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `instances` and `proof` are never read

warning: fields `instances` and `proof` are never read
 --> halo2_backend/src/plonk/verifier/batch.rs:6:5
  |
5 | struct BatchItem<C: CurveAffine> {
  |        --------- fields in this struct
6 |     instances: Vec<Vec<Vec<C::ScalarExt>>>,
  |     ^^^^^^^^^
7 |     proof: Vec<u8>,
  |     ^^^^^
  |
  = note: `BatchItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
  = note: `#[warn(dead_code)]` on by default

Check warning on line 313 in halo2_proofs/benches/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/benches/plonk.rs:313:17
    |
313 |                 &vk,
    |                 ^^^ help: change this to: `vk`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

Check warning on line 340 in halo2_proofs/benches/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `k`

warning: unused variable: `k`
   --> halo2_proofs/benches/plonk.rs:340:19
    |
340 |             |b, &(k, params, pk)| {
    |                   ^ help: if this is intentional, prefix it with an underscore: `_k`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 48 in halo2_backend/src/poly/query.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `blind` is never read

warning: field `blind` is never read
  --> halo2_backend/src/poly/query.rs:48:16
   |
46 | pub struct PolynomialPointer<'com, C: CurveAffine> {
   |            ----------------- field in this struct
47 |     pub(crate) poly: &'com Polynomial<C::Scalar, Coeff>,
48 |     pub(crate) blind: Blind<C::Scalar>,
   |                ^^^^^
   |
   = note: `PolynomialPointer` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis

Check warning on line 6 in halo2_backend/src/plonk/verifier/batch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `instances` and `proof` are never read

warning: fields `instances` and `proof` are never read
 --> halo2_backend/src/plonk/verifier/batch.rs:6:5
  |
5 | struct BatchItem<C: CurveAffine> {
  |        --------- fields in this struct
6 |     instances: Vec<Vec<Vec<C::ScalarExt>>>,
  |     ^^^^^^^^^
7 |     proof: Vec<u8>,
  |     ^^^^^
  |
  = note: `BatchItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
  = note: `#[warn(dead_code)]` on by default