Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: speed up unsafe_setup #63

Merged
merged 4 commits into from
May 3, 2022
Merged

opt: speed up unsafe_setup #63

merged 4 commits into from
May 3, 2022

Conversation

lispc
Copy link

@lispc lispc commented Apr 15, 2022

since we know s here, we don't need to do ifft. Directly computing lagranges is much faster.

for k = 16, reduce setup time from 40s to 4s

@lispc lispc mentioned this pull request Apr 27, 2022
Closed
CPerezz
CPerezz reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about the inversion.

The rest makes sense.

halo2_proofs/src/poly/commitment.rs Outdated Show resolved Hide resolved
@CPerezz CPerezz mentioned this pull request May 2, 2022
Closed
CPerezz
CPerezz approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks!!!

@CPerezz CPerezz merged commit d0489c7 into privacy-scaling-explorations:main May 3, 2022
@lispc lispc deleted the opt/commit_setup branch May 6, 2022 06:44
@mratsim mratsim mentioned this pull request Dec 7, 2023
Closed
mratsim pushed a commit to taikoxyz/halo2 that referenced this pull request Jan 16, 2024
@Velaciela
feature flag: mock-batch-inv (privacy-scaling-explorations#63)
aa86c10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPerezz CPerezz CPerezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lispc @CPerezz