Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: include more fields to transcript #351

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

guorong009
Copy link

Description

  • Add more conditionally-debugged fields to transcript_repr

Related issues

Changes

  • add multi-phase related challenge fields to PinnedConstraintSystem::fmt
  • update the plonk_api test

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (d52ebca) to head (2cd5d8f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   81.89%   81.86%   -0.03%     
==========================================
  Files          82       82              
  Lines       17008    16984      -24     
==========================================
- Hits        13928    13904      -24     
  Misses       3080     3080              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guorong009
Copy link
Author

@ed255 @han0110
Before I merge the PR, can you check if any more fields should be added to transcript_repr?
If you think no more, then I will merge the PR.

@han0110
Copy link

han0110 commented Jun 7, 2024

I think this is all, but I just realized we could just bring back the #[derive(Debug)] like in upstream, so we are sure we will not miss any fields.

@guorong009 guorong009 merged commit e86b7f7 into main Jun 7, 2024
18 checks passed
@guorong009 guorong009 deleted the gr@transcript-include-conditional-fields branch June 7, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include more fields within transcript prior to a new major version release
4 participants