Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix: random generator in ZAL MSM test #344

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

davidnevadoc
Copy link

Continuation of #340

Changes

  • Fix random generator of point and scalars
  • Increase test MSM size from k=4 to k=12

Also increased the size of the test MSM from k=4 to k=12.
Still runs in a couple seconds.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (e931d58) to head (794e5ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files          82       82           
  Lines       17017    17019    +2     
=======================================
+ Hits        13937    13939    +2     
  Misses       3080     3080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidnevadoc davidnevadoc requested a review from adria0 May 29, 2024 16:26
Copy link
Member

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidnevadoc davidnevadoc merged commit 80e69b9 into main May 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants