reexport halo2curves
in halo2_middleware
so users don't need it as explicit dep
#323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way users of
halo2_middleware
don't need to depend explicitly onhalo2curves
. Relevant context:mratsim/constantine#377
Q: Given that all the other modules part of the workspace depend on
halo2_middleware
, should one update the Cargo.toml files of those to remove the explicithalo2curves
dep? Seems like a sane idea (with my very limited rust experience) to remove the number of explicit dependencies with version numbers to avoid possible conflicts?Q2: Also, it seems like all the Cargo.toml files still point to the original zcash repo. Oversight? Should they be updated (it seems to me like it'll remain a fork, no?)
~~Q3: Should the
halo2curves
version be updated to0.6.1
? ~~ Since learned that0.6.0
allows for0.6.1
.