Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reexport halo2curves in halo2_middleware so users don't need it as explicit dep #323

Merged
merged 2 commits into from
May 14, 2024

Conversation

Vindaar
Copy link

@Vindaar Vindaar commented May 7, 2024

This way users of halo2_middleware don't need to depend explicitly on halo2curves. Relevant context:
mratsim/constantine#377

Q: Given that all the other modules part of the workspace depend on halo2_middleware, should one update the Cargo.toml files of those to remove the explicit halo2curves dep? Seems like a sane idea (with my very limited rust experience) to remove the number of explicit dependencies with version numbers to avoid possible conflicts?

Q2: Also, it seems like all the Cargo.toml files still point to the original zcash repo. Oversight? Should they be updated (it seems to me like it'll remain a fork, no?)

~~Q3: Should the halo2curves version be updated to 0.6.1? ~~ Since learned that 0.6.0 allows for 0.6.1.

@davidnevadoc
Copy link

davidnevadoc commented May 9, 2024

The dependency should also be updated in halo2_backend and halo2_frontend right?

Also, it seems like all the Cargo.toml files still point to the original zcash repo. Oversight? Should they be updated (it seems to me like it'll remain a fork, no?)

Good catch, I think they should be updated, yes.

@Vindaar
Copy link
Author

Vindaar commented May 11, 2024

The dependency should also be updated in halo2_backend and halo2_frontend right?

Can you clarify what you mean?

Also, it seems like all the Cargo.toml files still point to the original zcash repo. Oversight? Should they be updated (it seems to me like it'll remain a fork, no?)

Good catch, I think they should be updated, yes.

Done (and also updated the doc link).

@ed255
Copy link
Member

ed255 commented May 13, 2024

This way users of halo2_middleware don't need to depend explicitly on halo2curves. Relevant context: mratsim/constantine#377

Q: Given that all the other modules part of the workspace depend on halo2_middleware, should one update the Cargo.toml files of those to remove the explicit halo2curves dep? Seems like a sane idea (with my very limited rust experience) to remove the number of explicit dependencies with version numbers to avoid possible conflicts?

I think a better option would be to define the common dependencies in the workspace Cargo.toml following this https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table

~~Q3: Should the halo2curves version be updated to 0.6.1? ~~ Since learned that 0.6.0 allows for 0.6.1.

Sounds good to me to update it to 0.6.1.

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ed255 ed255 merged commit 620176c into privacy-scaling-explorations:main May 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants