Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable the features in halo2_proofs crate #319

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: enable the features in halo2_proofs crate #319

merged 1 commit into from
Apr 26, 2024

Conversation

guorong009
Copy link

Description

Check & enable the halo2_backend & halo2_frontend features in halo2_proofs crate features

Related issues

  • None

Changes

  • remove gadget-traces & cost-estimator feature from halo2_backend crate features
  • remove sanity-checks feature from halo2_frontend crate features
  • enable the necessary features in halo2_proofs crate features

@guorong009 guorong009 self-assigned this Apr 26, 2024
davidnevadoc
davidnevadoc approved these changes Apr 26, 2024
View reviewed changes
Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ed255
ed255 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@guorong009 guorong009 merged commit 9eedeb5 into main Apr 26, 2024
15 checks passed
@guorong009 guorong009 deleted the gr@fix-enable-features branch April 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnevadoc davidnevadoc davidnevadoc approved these changes

@ed255 ed255 ed255 approved these changes

@adria0 adria0 Awaiting requested review from adria0

Assignees

@guorong009 guorong009

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guorong009 @davidnevadoc @ed255