forked from zcash/halo2
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "frontend" column types from middleware to the frontend #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove phase from Advice - remove metadata::Column in favour of ColumnMid - move Fixed, Advice, Instance, ColumnType, Column, sealed from middleware to frontend
Overall, the PR looks good! @ed255 |
CPerezz
reviewed
Mar 21, 2024
CPerezz
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this work!
duguorong009
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #270
Fixed
,Advice
,Instance
,ColumnType
,Column
,sealed
frommiddleware to frontend
Fixed, Advice, Instance
types are used in the genericColumn<C>
type which is useful for the fronted because it brings type safety for column types; but in the backend it's unneeded because we use the simplified typeColumnMid
.Advice
Advice
was redundant because a column always exists in the context of aConstraintSystem
which has theadvice_column_phase
with that same information. This removal simplifies the code.From<(Any, usize)> for Column
in favor of using constructors in order to improve code clarity.