remove: multiexp_serial for halo2curves version
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed255
approved these changes
Feb 21, 2024
Will probably do it in a separated PR such that we have an atomic way to rollback in case it's needed. Sounds good? |
sounds good! |
|
You can also remove see cc7b71f |
This removes the entire definition of `multiexp_serial` and replaces it's usage for the `halo2curves` version (which is the same exact one). This was seen while reviewing #277 and will save the deprecation of the method and instead will completelly remove it.
CPerezz
force-pushed
the
remove/duplicated_multiexp_serial
branch
from
5d15843
to
b1f43fa
Compare
CPerezz
added a commit
that referenced
this pull request
Feb 26, 2024
We remove duplicated code from `halo2` which now is externalized (and more optimal) in `halo2curves`. This is a followup of #282
CPerezz
added a commit
that referenced
this pull request
Feb 27, 2024
* remove: best_{fft/multiexp} and use halo2curves
We remove duplicated code from `halo2` which now is externalized (and
more optimal) in `halo2curves`.
This is a followup of #282
* remove: Unused functions from arithmetic
* remove: FFT & MSM benches
As these are now handled by halo2curves. There's no need to bench here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the entire definition of
multiexp_serialand replaces it's usage for thehalo2curvesversion (which is similar and has the same functionality apparently).This was seen while reviewing #277 and will save the deprecation of the method and instead will completely remove it.
cc: @kilic to make sure that the most performant variant (as they're not the same exact code).