Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correcting few mistakes in documentation #240

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

IssouChancla
Copy link

Hey, found few errors in the documentation while reading it, should be good now.
Doesn't require testing or changelog entry.

@CPerezz
Copy link
Member

CPerezz commented Dec 18, 2023

Another of these bots trying to collect airdrops for fake GH collaborations LOL.
It's out of hand.

@ed255 @davidnevadoc I remember we discussed that. What shall we do?

@ed255
Copy link
Member

ed255 commented Dec 18, 2023

Another of these bots trying to collect airdrops for fake GH collaborations LOL. It's out of hand.

@ed255 @davidnevadoc I remember we discussed that. What shall we do?

I think they may not be bots (although it's hard to figure out). If we believe they are not bots, and the typo fixes are correct, I think it's OK to merge the PR.

@CPerezz
Copy link
Member

CPerezz commented Dec 18, 2023

I think they may not be bots (although it's hard to figure out). If we believe they are not bots, and the typo fixes are correct, I think it's OK to merge the PR.

Why having a private commit history then? Looks sus @ed255

@ed255
Copy link
Member

ed255 commented Dec 18, 2023

I think they may not be bots (although it's hard to figure out). If we believe they are not bots, and the typo fixes are correct, I think it's OK to merge the PR.

Why having a private commit history then? Looks sus @ed255

I assume this user is recent, and has a bunch of open PRs of the same kind, and that may be why they keep their profile private.
Like these:

Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright @ed255 !

LGTM

@IssouChancla
Copy link
Author

I think they may not be bots (although it's hard to figure out). If we believe they are not bots, and the typo fixes are correct, I think it's OK to merge the PR.

Why having a private commit history then? Looks sus @ed255

I assume this user is recent, and has a bunch of open PRs of the same kind, and that may be why they keep their profile private. Like these:

* [chore(ui): typo fix tahowallet/extension#3709](https://github.com/tahowallet/extension/pull/3709)

* [Fix website grammatical errors risc0/risc0#1242](https://github.com/risc0/risc0/pull/1242)

* [chore(kevm-pyk/src): typo fix runtimeverification/evm-semantics#2225](https://github.com/runtimeverification/evm-semantics/pull/2225)

Hey, yes I do, I'm also pretty easily doxxable so I tend to make all my socials private.
I'm not a bot and all my fix are "handmade" and handchecked, so there is 70% or more false positive.
I can work on codespell workflow implementation if wished.

I know typos aren't major changes but I hope I can help in any way even if it's not much.

Have a nice evening.

@CPerezz CPerezz merged commit 20c1290 into privacy-scaling-explorations:main Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants