Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish necessary properties for external use of KZG commitment #232

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

chiro-hiro
Copy link

This pull request was created to solve the issue that mentioned in #230

Copy link

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make getter functions instead of exposing the fields? The idea is that while we allow to retrieve this, we signal that they should not be edited.

Does it make sense?

@chiro-hiro
Copy link
Author

Hi @han0110 and @CPerezz, thank for the reply.

I have a call with my teammate and I think they misunderstood between construction method and public properties. I changed back the accessibilities of properties to pub(crate) and add the construction instead.

halo2_proofs/src/poly/query.rs Show resolved Hide resolved
halo2_proofs/src/poly/query.rs Show resolved Hide resolved
halo2_proofs/src/poly/query.rs Show resolved Hide resolved
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Still not 100% convinced that this should be exposed. But anyways, don't see strong reasons to prevent it. Aside that users might get confused thinking that this is needed for anything if you want to use the crate on a normal way.

@CPerezz CPerezz merged commit 6fc6d7c into privacy-scaling-explorations:main Nov 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants