Add keccak256 hasher for transcript #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/transcript.rs
Outdated
Comment on lines
386
to
389
| let hasher_lo = state_lo.clone(); | ||
| let hasher_hi = state_hi.clone(); | ||
| let result_lo: [u8; 32] = hasher_lo.finalize().as_slice().try_into().unwrap(); | ||
| let result_hi: [u8; 32] = hasher_hi.finalize().as_slice().try_into().unwrap(); |
There was a problem hiding this comment.
Do we need the hasher_* variables?
Suggested change
| let hasher_lo = state_lo.clone(); | |
| let hasher_hi = state_hi.clone(); | |
| let result_lo: [u8; 32] = hasher_lo.finalize().as_slice().try_into().unwrap(); | |
| let result_hi: [u8; 32] = hasher_hi.finalize().as_slice().try_into().unwrap(); | |
| let result_lo: [u8; 32] = state_lo.finalize().as_slice().try_into().unwrap(); | |
| let result_hi: [u8; 32] = state_hi.finalize().as_slice().try_into().unwrap(); |
src/transcript.rs
Outdated
Comment on lines
223
to
228
| state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]); | ||
| state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]); | ||
| let hasher_lo = state_lo.clone(); | ||
| let hasher_hi = state_hi.clone(); | ||
| let result_lo: [u8; 32] = hasher_lo.finalize().as_slice().try_into().unwrap(); | ||
| let result_hi: [u8; 32] = hasher_hi.finalize().as_slice().try_into().unwrap(); |
There was a problem hiding this comment.
Suggested change
| state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]); | |
| state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]); | |
| let hasher_lo = state_lo.clone(); | |
| let hasher_hi = state_hi.clone(); | |
| let result_lo: [u8; 32] = hasher_lo.finalize().as_slice().try_into().unwrap(); | |
| let result_hi: [u8; 32] = hasher_hi.finalize().as_slice().try_into().unwrap(); | |
| state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]); | |
| state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]); | |
| let result_lo: [u8; 32] = state_lo.finalize().as_slice().try_into().unwrap(); | |
| let result_hi: [u8; 32] = state_hi.finalize().as_slice().try_into().unwrap(); |
jonathanpwang
referenced
this pull request
in axiom-crypto/halo2
Nov 9, 2022
Implement `ff::PrimeField::to_repr` for `bn256::Fq2`
|
We need to rebase and merge this. @kilic |
kilic
force-pushed
the
keccak_transcript
branch
from
61a4cd0
to
e0b7d10
Compare
volhovm
pushed a commit
to volhovm/halo2
that referenced
this pull request
Mar 30, 2023
…ijie/gpu fix: align timer
span14
pushed a commit
to span14/halo2
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keccak256 option added to transcript.
What is different than blake2b procedure is output size of keccak256 is 32 bytes where it is 64 with blake2. We can of cource find a field element from 32 bytes of keccak256 output but it'd introduce a modulus bias. So in order to make output 64 bytes we followed the approach below.
Notice that whereas
KECCAK256_PREFIX_CHALLENGEis contributed to the running stateKECCAK256_PREFIX_CHALLENGE_LOandKECCAK256_PREFIX_CHALLENGE_HIprefixes are forking the state.Two 32 bytes result is concatenated to be reduced into a field element with
from_u512method.